fix(ui5-multi-combobox): set correct height to items checkboxes (#5216)

MapTo0 · web-flow · commit 0946207446ef · 2022-05-25T16:57:22.000+03:00
FIXES: #5126
diff --git a/packages/main/src/MultiComboBox.js b/packages/main/src/MultiComboBox.js
@@ -72,6 +72,7 @@ import styles from "./generated/themes/MultiComboBox.css.js";
 import ResponsivePopoverCommonCss from "./generated/themes/ResponsivePopoverCommon.css.js";
 import ValueStateMessageCss from "./generated/themes/ValueStateMessage.css.js";
 import SuggestionsCss from "./generated/themes/Suggestions.css.js";
+import MultiComboBoxPopover from "./generated/themes/MultiComboBoxPopover.css.js";
 
 /**
  * @public
@@ -431,7 +432,7 @@ class MultiComboBox extends UI5Element {
 	}
 
 	static get staticAreaStyles() {
-		return [ResponsivePopoverCommonCss, ValueStateMessageCss, SuggestionsCss];
+		return [ResponsivePopoverCommonCss, ValueStateMessageCss, SuggestionsCss, MultiComboBoxPopover];
 	}
 
 	static get dependencies() {
diff --git a/packages/main/src/themes/MultiComboBoxPopover.css b/packages/main/src/themes/MultiComboBoxPopover.css
@@ -0,0 +1,3 @@
+.ui5-suggestions-popover .ui5-multi-combobox-all-items-list {
+	--_ui5_checkbox_width_height: var(--_ui5_list_item_dropdown_base_height);
+}

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,7 @@ import styles from "./generated/themes/MultiComboBox.css.js";`
`72`	`72`	`import ResponsivePopoverCommonCss from "./generated/themes/ResponsivePopoverCommon.css.js";`
`73`	`73`	`import ValueStateMessageCss from "./generated/themes/ValueStateMessage.css.js";`
`74`	`74`	`import SuggestionsCss from "./generated/themes/Suggestions.css.js";`
	`75`	`+import MultiComboBoxPopover from "./generated/themes/MultiComboBoxPopover.css.js";`
`75`	`76`
`76`	`77`	`/**`
`77`	`78`	`* @public`
`@@ -431,7 +432,7 @@ class MultiComboBox extends UI5Element {`
`431`	`432`	`}`
`432`	`433`
`433`	`434`	`static get staticAreaStyles() {`
`434`		`- return [ResponsivePopoverCommonCss, ValueStateMessageCss, SuggestionsCss];`
	`435`	`+ return [ResponsivePopoverCommonCss, ValueStateMessageCss, SuggestionsCss, MultiComboBoxPopover];`
`435`	`436`	`}`
`436`	`437`
`437`	`438`	`static get dependencies() {`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+.ui5-suggestions-popover .ui5-multi-combobox-all-items-list {`
	`2`	`+ --_ui5_checkbox_width_height: var(--_ui5_list_item_dropdown_base_height);`
	`3`	`+}`