refactor(ui5-popover): hideHeader property renamed to noHeader (#553)

fifoosid · web-flow · commit 11dc3b1c4d86 · 2019-06-17T13:37:30.000+03:00
BREAKING CHANGE: hideHeader property renamed to noHeader
diff --git a/packages/main/src/DatePicker.hbs b/packages/main/src/DatePicker.hbs
@@ -30,7 +30,7 @@
 			id="{{_id}}-popover"
 			allow-target-overlap="{{_popover.allowTargetOverlap}}"
 			placement-type="{{_popover.placementType}}"
-			hide-header="{{_popover.hideHeader}}"
+			no-header="{{_popover.noHeader}}"
 			hide-arrow="{{_popover.hideArrow}}"
 			horizontal-align="{{_popover.horizontalAlign}}"
 			stay-open-on-scroll="{{_popover.stayOpenOnScroll}}"
diff --git a/packages/main/src/DatePicker.js b/packages/main/src/DatePicker.js
@@ -253,7 +253,7 @@ class DatePicker extends UI5Element {
 		this._popover = {
 			placementType: PopoverPlacementType.Bottom,
 			horizontalAlign: PopoverHorizontalAlign.Left,
-			hideHeader: true,
+			noHeader: true,
 			hideArrow: true,
 			allowTargetOverlap: true,
 			stayOpenOnScroll: true,
diff --git a/packages/main/src/Dialog.hbs b/packages/main/src/Dialog.hbs
@@ -18,7 +18,7 @@
 </span>
 
 {{#*inline "header"}}
-	{{#unless hideHeader}}
+	{{#unless noHeader}}
 		<header>
 			{{#if header}}
 				<div role="heading" class="sapMPopupHeader">
diff --git a/packages/main/src/Input.hbs b/packages/main/src/Input.hbs
@@ -30,7 +30,7 @@
 	{{#if showSuggestions}}
 			<ui5-popover
 				placement-type="Bottom"
-				hide-header="true"
+				no-header="true"
 				hide-arrow="true"
 				horizontal-align="Stretch"
 				initial-focus="{{_id}}-inner">
diff --git a/packages/main/src/MultiComboBox.hbs b/packages/main/src/MultiComboBox.hbs
@@ -36,7 +36,7 @@
 	<ui5-popover 
 		class="ui5-multi-combobox-selected-items--popover"
 		horizontal-align="Stretch"
-		hide-header
+		no-header
 		?hide-arrow={{editable}}
 		placement-type="Bottom">
 		<ui5-list separators="None" mode="{{selectedItemsListMode}}"
@@ -50,7 +50,7 @@
 	</ui5-popover>
 
 	<ui5-popover class="ui5-multi-combobox-all-items--popover"
-		hide-header
+		no-header
 		hide-arrow
 		horizontal-align="Stretch"
 		initial-focus="ui5-multi-combobox--input"
diff --git a/packages/main/src/Popover.hbs b/packages/main/src/Popover.hbs
@@ -15,7 +15,7 @@
 </span>
 
 {{#*inline "header"}}
-	{{#unless hideHeader}}
+	{{#unless noHeader}}
 		<header>
 			{{#if header}}
 				<div role="toolbar" class="sapMPopupHeader">
diff --git a/packages/main/src/Popover.js b/packages/main/src/Popover.js
@@ -471,7 +471,7 @@ class Popover extends Popup {
 
 		let maxContentHeight = Math.round(maxHeight);
 
-		if (!this.hideHeader) {
+		if (!this.noHeader) {
 			const headerDomRef = this.getPopupDomRef().querySelector(".sapMPopupHeader");
 			if (headerDomRef) {
 				maxContentHeight = Math.round(maxHeight - headerDomRef.offsetHeight);
@@ -649,7 +649,7 @@ class Popover extends Popup {
 	}
 
 	get headerId() {
-		return this.hideHeader ? undefined : `${this._id}-header`;
+		return this.noHeader ? undefined : `${this._id}-header`;
 	}
 
 	get focusHelper() {
diff --git a/packages/main/src/Popup.js b/packages/main/src/Popup.js
@@ -68,7 +68,7 @@ const metadata = {
 		 * @defaultvalue false
 		 * @public
 		 */
-		hideHeader: {
+		noHeader: {
 			type: Boolean,
 		},
 		/**
diff --git a/packages/main/src/Select.hbs b/packages/main/src/Select.hbs
@@ -12,7 +12,7 @@
 	{{#if items}}
 		<ui5-popover
 			placement-type="Bottom"
-			hide-header="true"
+			no-header="true"
 			hide-arrow="true"
 			horizontal-align="Stretch">
 				<ui5-list separators="None">
diff --git a/packages/main/src/ShellBar.hbs b/packages/main/src/ShellBar.hbs
@@ -28,7 +28,7 @@
 			</button>
 		{{/if}}
 
-		<ui5-popover class="sapWCShellBarMenuPopover" hide-header placement-type="Bottom">
+		<ui5-popover class="sapWCShellBarMenuPopover" no-header placement-type="Bottom">
 			<ui5-list separators="None" mode="SingleSelect" @ui5-itemPress={{_menuItemPress}}>
 				<slot name="menuItems"></slot>
 			</ui5-list>
@@ -75,7 +75,7 @@
 		</div>
 	</div>
 
-	<ui5-popover class="sapWCShellBarOverflowPopover" placement-type="Bottom" horizontal-align="{{popoverHorizontalAlign}}" hide-header hide-arrow>
+	<ui5-popover class="sapWCShellBarOverflowPopover" placement-type="Bottom" horizontal-align="{{popoverHorizontalAlign}}" no-header hide-arrow>
 		<ui5-list separators="None" @ui5-itemPress="{{_actionList.itemPress}}">
 			{{#each _hiddenIcons}}
 				<ui5-li
diff --git a/packages/main/src/TabContainer.hbs b/packages/main/src/TabContainer.hbs
@@ -73,7 +73,7 @@
 	<ui5-popover
 		id="{{_id}}-overflowMenu"
 		hide-arrow
-		hide-header
+		no-header
 		placement-type="Bottom"
 		horizontal-align="Right">
 		<ui5-list @ui5-itemPress="{{_overflowList.click}}">
diff --git a/packages/main/test/sap/ui/webcomponents/main/pages/Popups.html b/packages/main/test/sap/ui/webcomponents/main/pages/Popups.html
@@ -66,7 +66,7 @@
 		<content id="popover"></content>
 	</div>
 
-	<ui5-popover placement-type="Bottom" horizontal-align="Stretch" hide-arrow hide-header initial-focus="input1" class="wcPopoverWithList">
+	<ui5-popover placement-type="Bottom" horizontal-align="Stretch" hide-arrow no-header initial-focus="input1" class="wcPopoverWithList">
 		<ui5-list id="myList" inset separators="Inner" mode="MultiSelect" footer-text="Copyright" no-data-text="No data">
 			<!-- Header -->
 			<div style="display: flex; align-items: center;" slot="header">
diff --git a/packages/main/test/sap/ui/webcomponents/main/pages/ShellBar.html b/packages/main/test/sap/ui/webcomponents/main/pages/ShellBar.html
@@ -132,7 +132,7 @@
 		<ui5-li slot="menuItems">Application 5</ui5-li>
 	</ui5-shellbar>
 
-	<ui5-popover id="popover" hide-header placement-type="Bottom">
+	<ui5-popover id="popover" no-header placement-type="Bottom">
 		<div class="popover-header">
 			<ui5-title style="padding: 0.25rem 1rem 0rem 1rem">John Doe</ui5-title>
 		</div>
@@ -148,7 +148,7 @@
 		</div>
 	</ui5-popover>
 
-	<ui5-popover id="app-list-popover" hide-header placement-type="Bottom">
+	<ui5-popover id="app-list-popover" no-header placement-type="Bottom">
 		<ui5-list separators="None">
 			<ui5-li>Application 1</ui5-li>
 			<ui5-li>Application 2</ui5-li>
@@ -158,7 +158,7 @@
 		</ui5-list>
 	</ui5-popover>
 
-	<ui5-popover id="custom-item-popover" hide-header placement-type="Bottom">
+	<ui5-popover id="custom-item-popover" no-header placement-type="Bottom">
 		<ui5-list separators="None">
 			<ui5-li id="custom-item-1" type="Active">Custom Popover Item 1</ui5-li>
 			<ui5-li type="Active">Custom Popover Item 2</ui5-li>
diff --git a/packages/main/test/sap/ui/webcomponents/main/samples/ShellBar.sample.html b/packages/main/test/sap/ui/webcomponents/main/samples/ShellBar.sample.html
@@ -75,7 +75,7 @@ <h3>ShellBar</h3>
 	<ui5-li slot="menuItems">Application 5</ui5-li>
 </ui5-shellbar>
 
-<ui5-popover id="action-popover" hide-header placement-type="Bottom">
+<ui5-popover id="action-popover" no-header placement-type="Bottom">
 	<div class="action-popover-header">
 		<ui5-title style="padding: 0.25rem 1rem 0rem 1rem">An Kimura</ui5-title>
 	</div>
@@ -128,7 +128,7 @@ <h3>ShellBar</h3>
 
 </ui5-shellbar>
 
-<ui5-popover id="popover" hide-header placement-type="Bottom">
+<ui5-popover id="popover" no-header placement-type="Bottom">
 	<div class="popover-header">
 		<ui5-title style="padding: 0.25rem 1rem 0rem 1rem">An Kimura</ui5-title>
 	</div>

Original file line number	Diff line number	Diff line change
`@@ -471,7 +471,7 @@ class Popover extends Popup {`
`471`	`471`
`472`	`472`	`let maxContentHeight = Math.round(maxHeight);`
`473`	`473`
`474`		`- if (!this.hideHeader) {`
	`474`	`+ if (!this.noHeader) {`
`475`	`475`	`const headerDomRef = this.getPopupDomRef().querySelector(".sapMPopupHeader");`
`476`	`476`	`if (headerDomRef) {`
`477`	`477`	`maxContentHeight = Math.round(maxHeight - headerDomRef.offsetHeight);`
`@@ -649,7 +649,7 @@ class Popover extends Popup {`
`649`	`649`	`}`
`650`	`650`
`651`	`651`	`get headerId() {`
`652`		- return this.hideHeader ? undefined : `${this._id}-header`;
	`652`	+ return this.noHeader ? undefined : `${this._id}-header`;
`653`	`653`	`}`
`654`	`654`
`655`	`655`	`get focusHelper() {`