Skip to content

Commit 381c884

Browse files
authored
fix(ui5-date-picker): remove aria-expanded attribute (#4866)
The aria-expanded attribute is removed from the ui5-date-picker, ui5-daterange-picker, ui5-datetime-picker input element for compliance with the combobox role removal. Fixes: #4865
1 parent 01b56f3 commit 381c884

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

packages/main/src/DatePicker.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,6 @@ class DatePicker extends DateComponentBase {
677677
"ariaHasPopup": HasPopup.Grid,
678678
"ariaAutoComplete": "none",
679679
"ariaControls": `${this._id}-responsive-popover`,
680-
"ariaExpanded": this.isOpen(),
681680
"ariaRequired": this.required,
682681
"ariaLabel": getEffectiveAriaLabelText(this),
683682
};

packages/main/src/TimePicker.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,7 @@ class TimePicker extends TimePickerBase {
150150
"ariaRoledescription": this.dateAriaDescription,
151151
"ariaHasPopup": "dialog",
152152
"ariaAutoComplete": "none",
153-
"role": "combobox",
154153
"ariaControls": `${this._id}-responsive-popover`,
155-
"ariaExpanded": this.isOpen(),
156154
};
157155
}
158156

packages/main/test/specs/DatePicker.spec.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ describe("Date Picker Tests", () => {
1717
assert.ok(await innerInput.isDisplayedInViewport(), "inner input is rendered");
1818
assert.strictEqual(await innerInput.getAttribute("aria-roledescription"), "Date Input", "aria-roledescription attribute is added.");
1919
assert.strictEqual(await innerInput.getAttribute("aria-haspopup"), "Grid", "aria-haspopup attribute is added.");
20+
assert.notOk(await innerInput.getAttribute("aria-expanded"), "aria-expanded attribute isn't rendered.");
2021
});
2122

2223
it("input receives value", async () => {

0 commit comments

Comments
 (0)