Skip to content

Commit 4b25668

Browse files
committed
fix(ui5-responsive-popover): fix header styles (#3176)
We use lit-html classMaps to render classes out of objects , but it works with this getter "get classes()" not with any getters. FIXES: #3173
1 parent 536e917 commit 4b25668

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

packages/main/src/ResponsivePopover.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
{{#if header.length}}
1414
<slot slot="header" name="header"></slot>
1515
{{else}}
16-
<header class="{{dialogClasses.header}}">
16+
<header class="{{classes.header}}">
1717
{{#if headerText }}
1818
<ui5-title level="H2" class="ui5-popup-header-text ui5-responsive-popover-header-text">{{headerText}}</ui5-title>
1919
{{/if}}

packages/main/src/ResponsivePopover.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,13 +90,15 @@ class ResponsivePopover extends Popover {
9090
return [Popover.styles, ResponsivePopoverCss];
9191
}
9292

93-
get dialogClasses() {
94-
return {
95-
header: {
96-
"ui5-responsive-popover-header": true,
97-
"ui5-responsive-popover-header-no-title": !this.headerText,
98-
}
99-
}
93+
get classes() {
94+
const allClasses = super.classes;
95+
96+
allClasses.header = {
97+
"ui5-responsive-popover-header": true,
98+
"ui5-responsive-popover-header-no-title": !this.headerText,
99+
};
100+
101+
return allClasses;
100102
}
101103

102104
static get template() {

packages/main/test/pages/ResponsivePopover.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,11 @@ <h2> Inputs based component that opens popover/dialog within dialog</h2>
130130
});
131131

132132
btnSimpleRP.addEventListener("click", function(event) {
133-
simpleRP.openBy(btnSimpleRP);
133+
simpleRP.open(btnSimpleRP);
134134
});
135135

136136
btnRpTopWithArrow.addEventListener("click", function(event) {
137-
rpTopWithArrow.openBy(btnRpTopWithArrow);
137+
rpTopWithArrow.open(btnRpTopWithArrow);
138138
});
139139
</script>
140140
</body>

0 commit comments

Comments
 (0)