Skip to content

Commit 685d4ba

Browse files
fix(ui5-view-settings-dialog): including title in initial reading (#4827)
related to: #4660
1 parent 25d1472 commit 685d4ba

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

packages/fiori/src/ViewSettingsDialog.hbs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,16 @@
1818
<ui5-title>{{_filterByTitle}}</ui5-title>
1919
{{else}}
2020
<div class="ui5-vsd-bar-title">
21-
<ui5-title class="ui5-vsd-title">{{_dialogTitle}}</ui5-title>
21+
<ui5-title class="ui5-vsd-title" id="{{_id}}-label">{{_dialogTitle}}</ui5-title>
2222
{{#if hasPagination}}
2323
<ui5-segmented-button @ui5-selection-change="{{_handleModeChange}}">
2424
<ui5-segmented-button-item
2525
?pressed="{{isModeSort}}"
26-
?focused="{{isModeSort}}"
2726
icon="sort"
2827
mode="Sort"
2928
></ui5-segmented-button-item>
3029
<ui5-segmented-button-item
3130
?pressed="{{isModeFilter}}"
32-
?focused="{{isModeFilter}}"
3331
icon="filter"
3432
mode="Filter"
3533
></ui5-segmented-button-item>

packages/fiori/src/ViewSettingsDialog.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,11 @@ class ViewSettingsDialog extends UI5Element {
476476
} else {
477477
this._restoreSettings(this._confirmedSettings);
478478
}
479-
this._dialog.show();
479+
480+
this._dialog.show(true);
481+
482+
this._dialog.querySelector("ui5-list").accessibleNameRef = `${this.id}-label`;
483+
this._dialog.querySelector("ui5-list").focusFirstItem();
480484
}
481485

482486
_handleModeChange(event) {

0 commit comments

Comments
 (0)