Skip to content

Commit 7353188

Browse files
authored
fix(ui5-combobox): disable autocomplete on Android (#5088)
1 parent 3eed2d3 commit 7353188

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

packages/base/src/Device.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,10 @@ const isIOS = () => {
103103
return iOS;
104104
};
105105

106+
const isAndroid = () => {
107+
return android || androidPhone;
108+
};
109+
106110
export {
107111
supportsTouch,
108112
isIE,
@@ -113,4 +117,5 @@ export {
113117
isDesktop,
114118
isCombi,
115119
isIOS,
120+
isAndroid,
116121
};

packages/main/src/ComboBox.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import UI5Element from "@ui5/webcomponents-base/dist/UI5Element.js";
22
import litRender from "@ui5/webcomponents-base/dist/renderer/LitRenderer.js";
33
import ValueState from "@ui5/webcomponents-base/dist/types/ValueState.js";
4-
import { isPhone, isSafari } from "@ui5/webcomponents-base/dist/Device.js";
4+
import { isPhone, isAndroid, isSafari } from "@ui5/webcomponents-base/dist/Device.js";
55
import Integer from "@ui5/webcomponents-base/dist/types/Integer.js";
66
import { getEffectiveAriaLabelText } from "@ui5/webcomponents-base/dist/util/AriaLabelHelper.js";
77
import announce from "@ui5/webcomponents-base/dist/util/InvisibleMessage.js";
@@ -571,7 +571,7 @@ class ComboBox extends UI5Element {
571571
this._clearFocus();
572572

573573
// autocomplete
574-
if (this._autocomplete) {
574+
if (this._autocomplete && !isAndroid()) {
575575
const item = this._getFirstMatchingItem(value);
576576
this._applyAtomicValueAndSelection(item, value, true);
577577

0 commit comments

Comments
 (0)