Skip to content

Commit 75023c1

Browse files
authored
fix(ui5-card): exploratory testing issues (#3881)
1 parent a46327d commit 75023c1

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

packages/main/src/CardHeader.hbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<div
22
class="{{classes}}"
3+
dir="{{effectiveDir}}"
34
@click="{{_headerClick}}"
45
@keydown="{{_headerKeydown}}"
56
@keyup="{{_headerKeyup}}"

packages/main/src/themes/CardHeader.css

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,21 +105,21 @@
105105
max-width: 100%;
106106
}
107107

108-
[dir="rtl"] .ui5-card-header .ui5-card-header-avatar {
108+
[dir="rtl"].ui5-card-header .ui5-card-header-avatar {
109109
margin-left: .75rem;
110110
margin-right: 0;
111111
}
112112

113-
[dir="rtl"] .ui5-card-header .ui5-card-header-status {
113+
[dir="rtl"].ui5-card-header .ui5-card-header-status {
114114
padding-right: 1rem;
115115
padding-left: 0rem;
116116
margin-right: auto;
117117
}
118118

119-
[dir="rtl"] .ui5-card-header .ui5-card-header-text .ui5-card-header-title {
119+
[dir="rtl"].ui5-card-header .ui5-card-header-text .ui5-card-header-title {
120120
text-align: right;
121121
}
122122

123-
[dir="rtl"] .ui5-card-header .ui5-card-header-text .ui5-card-header-subtitle {
123+
[dir="rtl"].ui5-card-header .ui5-card-header-text .ui5-card-header-subtitle {
124124
text-align: right;
125125
}

packages/main/test/samples/Card.sample.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,9 @@ <h3>Card with List</h3>
7272
<div class="snippet card-container">
7373
<ui5-card class="medium">
7474
<ui5-card-header slot="header" title-text="Team Space" subtitle-text="Direct Reports" status="3 of 10">
75+
<ui5-icon name="group" slot="avatar"></ui5-icon>
76+
<ui5-button design="Emphasized" slot="action">View All</ui5-button>
7577
</ui5-card-header>
76-
<ui5-icon name="group" slot="avatar"></ui5-icon>
77-
<ui5-button design="Emphasized" slot="action">View All</ui5-button>
7878

7979
<div class="card-content">
8080
<ui5-list separators="None" class="card-content-child" style="width: 100%">
@@ -112,8 +112,8 @@ <h3>Card with List</h3>
112112
<ui5-card class="medium">
113113
<ui5-card-header slot="header" title-text="Team Space" subtitle-text="Direct Reports" status="3 of 10">
114114
<ui5-icon name="group" slot="avatar"></ui5-icon>
115+
<ui5-button design="Emphasized" slot="action">View All</ui5-button>
115116
</ui5-card-header>
116-
<ui5-button design="Emphasized" slot="action">View All</ui5-button>
117117
<div class="card-content">
118118
<ui5-list separators="None" class="card-content-child" style="width: 100%">
119119
<ui5-li image="../../../assets/images/avatars/man_avatar_1.png" description="User Researcher">Alain Chevalier</ui5-li>

0 commit comments

Comments
 (0)