fix(ui5-multi-combobox): fix behavior of show all selected button (#2100

)
SAP · Aug 18, 2020 · 84362e0 · 84362e0
1 parent 20c55ed
commit 84362e0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/main/src/MultiComboBox.js b/packages/main/src/MultiComboBox.js
@@ -335,9 +335,22 @@ class MultiComboBox extends UI5Element {
 	}
 
 	filterSelectedItems(event) {
+		if (this.allItemsSelected) {
+			this.filterSelected = true;
+			return;
+		}
+
 		this.filterSelected = event.target.pressed;
 	}
 
+	get _showAllItemsButtonPressed() {
+		return this.filterSelected || this.allItemsSelected;
+	}
+
+	get allItemsSelected() {
+		return this.items.length === this.selectedValues.length;
+	}
+
 	get _inputDom() {
 		return this.shadowRoot.querySelector("#ui5-multi-combobox-input");
 	}

diff --git a/packages/main/src/MultiComboBoxPopover.hbs b/packages/main/src/MultiComboBoxPopover.hbs
@@ -44,7 +44,8 @@
 					class="ui5-multi-combobox-toggle-button"
 					icon="multiselect-all"
 					design="Transparent"
-					?pressed={{filterSelected}}
+					?pressed={{_showAllItemsButtonPressed}}
+					?disabled={{allItemsSelected}}
 					@click="{{filterSelectedItems}}"
 				></ui5-togglebutton>
 		</div>