Skip to content

Commit aba5fb5

Browse files
authored
fix(ui5-shellbar): correct accessibility DOM (#5395)
1 parent a359ebf commit aba5fb5

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

packages/fiori/src/ShellBar.hbs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,12 @@
2626
</span>
2727
{{/unless}}
2828

29+
{{#if showTitleInMenuButton}}
30+
<h1 class="ui5-hidden-text">
31+
{{primaryTitle}}
32+
</h1>
33+
{{/if}}
34+
2935
{{#if showMenuButton}}
3036
<button class="{{classes.button}}"
3137
@click="{{_header.press}}"
@@ -41,9 +47,9 @@
4147

4248

4349
{{#if showTitleInMenuButton}}
44-
<h1 class="ui5-shellbar-menu-button-title">
45-
<bdi>{{primaryTitle}}</bdi>
46-
</h1>
50+
<div class="ui5-shellbar-menu-button-title">
51+
{{primaryTitle}}
52+
</div>
4753
{{/if}}
4854

4955
<span class="ui5-shellbar-menu-button-arrow"></span>

packages/fiori/src/themes/ShellBar.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@import "./InvisibleTextStyles.css";
2+
13
:host(:not([hidden])) {
24
display: inline-block;
35
width: 100%;

0 commit comments

Comments
 (0)