fix(ui5-shellbar, ui5-breadcrumbs, ui5-barcode-scanner-dialog): align popover paddings (#4894)

Fixes: #4872

Author: nnaydenow

packages/fiori/src/BarcodeScannerDialog.hbs

@@ -1,4 +1,5 @@
 <ui5-dialog stretch
+	class="ui5-barcode-scanner-dialog-root"
 	dir={{effectiveDir}}
 	@ui5-before-open={{_startReader}}
 	@ui5-after-close={{_resetReader}}>

packages/fiori/src/BarcodeScannerDialog.js

@@ -10,7 +10,7 @@ import { BrowserMultiFormatReader, NotFoundException } from "@zxing/library";
 import BarcodeScannerDialogTemplate from "./generated/templates/BarcodeScannerDialogTemplate.lit.js";
 
 // Styles
-import barcodeScannerDialogCss from "./generated/themes/BarcodeScannerDialog.css.js";
+import BarcodeScannerDialogCss from "./generated/themes/BarcodeScannerDialog.css.js";
 
 // Texts
 import {
@@ -134,7 +134,7 @@ class BarcodeScannerDialog extends UI5Element {
 	}
 
 	static get staticAreaStyles() {
-		return [barcodeScannerDialogCss];
+		return [BarcodeScannerDialogCss];
 	}
 
 	static async onDefine() {

packages/fiori/src/ShellBar.js

@@ -35,6 +35,7 @@ import ShellBarPopoverTemplate from "./generated/templates/ShellBarPopoverTempla
 
 // Styles
 import styles from "./generated/themes/ShellBar.css.js";
+import ShellBarPopoverCss from "./generated/themes/ShellBarPopover.css.js";
 
 const HANDLE_RESIZE_DEBOUNCE_RATE = 200; // ms
 
@@ -413,10 +414,6 @@ class ShellBar extends UI5Element {
 		return metadata;
 	}
 
-	static get styles() {
-		return styles;
-	}
-
 	static get render() {
 		return litRender;
 	}
@@ -429,6 +426,14 @@ class ShellBar extends UI5Element {
 		return ShellBarPopoverTemplate;
 	}
 
+	static get styles() {
+		return styles;
+	}
+
+	static get staticAreaStyles() {
+		return [ShellBarPopoverCss];
+	}
+
 	static get FIORI_3_BREAKPOINTS() {
 		return [
 			599,

packages/fiori/src/ShellBarPopover.hbs

@@ -1,4 +1,5 @@
 <ui5-popover class="ui5-shellbar-menu-popover"
+	hide-arrow
 	placement-type="Bottom"
 	@ui5-before-open={{_menuPopoverBeforeOpen}}
 	@ui5-after-close={{_menuPopoverAfterClose}}

packages/fiori/src/themes/BarcodeScannerDialog.css

@@ -1,3 +1,7 @@
+.ui5-barcode-scanner-dialog-root::part(content) {
+    padding: .4375rem;
+}
+
 /* video */
 .ui5-barcode-scanner-dialog-video-wrapper,
 .ui5-barcode-scanner-dialog-video {

packages/fiori/src/themes/ShellBarPopover.css

@@ -0,0 +1,5 @@
+.ui5-shellbar-menu-popover::part(content),
+.ui5-shellbar-overflow-popover::part(content) {
+	padding: 0;
+}
+

packages/main/src/BreadcrumbsPopover.hbs

@@ -1,4 +1,5 @@
 <ui5-responsive-popover
+	class="ui5-breadcrumbs-popover"
 	hide-arrow
 	content-only-on-desktop
 	placement-type="Bottom"

packages/main/src/themes/BreadcrumbsPopover.css

@@ -1,3 +1,7 @@
+.ui5-breadcrumbs-popover::part(content) {
+    padding: 0;
+}
+
 .ui5-breadcrumbs-popover-footer {
     display: flex;
     justify-content: flex-end;