Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui5-time-picker): rename component #1802

Merged
merged 2 commits into from
Jun 18, 2020
Merged

chore(ui5-time-picker): rename component #1802

merged 2 commits into from
Jun 18, 2020

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Jun 15, 2020 •
edited
Loading

BREAKING_CHANGE: ui5-timepicker is renamed to ui5-time-picker

ilhan007
ilhan007 requested changes Jun 15, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better top register the old tags for some time.

@fifoosid fifoosid closed this Jun 16, 2020
@fifoosid fifoosid reopened this Jun 16, 2020
@fifoosid
Copy link
Contributor Author

This PR depends on #1801, for definition of the old class

@fifoosid fifoosid merged commit fcb2e9e into master Jun 18, 2020
@fifoosid fifoosid deleted the timepicker-tag branch June 18, 2020 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fifoosid @ilhan007