Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-multiinput): Improve valueStateMessage in nMore popover #2225

Merged
merged 6 commits into from
Sep 20, 2020

Conversation

ivoplashkov
Copy link
Member

FIXES: #1086

ValueStateMessage is now shown inside the nMore popover on both desktop and mobile devices.

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two issues so far:

  1. On phone, there is no header and the user can't close the popover once it is open

Screenshot 2020-09-18 at 10 24 00 AM

  1. I think on phone and desktop the value state message should has min-height equal to the height of the list item (as done in the Input)

Screenshot 2020-09-18 at 10 24 34 AM

@ilhan007 ilhan007 merged commit a03f2b3 into SAP:master Sep 20, 2020
ilhan007 pushed a commit that referenced this pull request Oct 17, 2020
ValueStateMessage is now shown inside the nMore popover on both desktop and mobile devices.

FIXES: #1086
ilhan007 pushed a commit that referenced this pull request Nov 11, 2020
ValueStateMessage is now shown inside the nMore popover on both desktop and mobile devices.

FIXES: #1086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input components - Value State Message
2 participants