Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover arrow for notifications shellbar not positioned correctly #2401

Closed
m-ignatov opened this issue Oct 27, 2020 · 2 comments · Fixed by #2917
Closed

Popover arrow for notifications shellbar not positioned correctly #2401

m-ignatov opened this issue Oct 27, 2020 · 2 comments · Fixed by #2917
Assignees
@georgimkv
Labels
bug This issue is a bug in the code Low Prio TOPIC RD

Comments

@m-ignatov
Copy link

Describe the bug
Popover arrow for notifications shellbar is not positioned correctly when the following popover attributes are set: placement-type="Bottom" horizontal-align="Right"

Isolated example
CodeSandbox

Actual (1.0.0-rc.9)
image

Expected (1.0.0-rc.8)
image

Context

  • UI5 Web Components version: 1.0.0-rc.9
@fifoosid fifoosid self-assigned this Nov 18, 2020
@fifoosid
Copy link
Contributor

Hi @m-ignatov

If you want to position the popover correctly in this use case, you should remove the horizontal-align="Right" attribute.

@m-ignatov
Copy link
Author

Hi @fifoosid

Thanks, I understand that.

However, this is still a visual bug when the popover horizontal align property is:
horizontal-align="Right" or horizontal-align="Left".

Please, consider reopening this issue.

Thanks :)

@ilhan007 ilhan007 reopened this Dec 9, 2020
@georgimkv georgimkv added the bug This issue is a bug in the code label Jan 14, 2021
@georgimkv georgimkv mentioned this issue Mar 8, 2021
Merged
@georgimkv georgimkv self-assigned this Mar 8, 2021
ilhan007 pushed a commit that referenced this issue Mar 12, 2021
@georgimkv
fix(ui5-popup): position arrows correctly (#2917)
5ffbbd9 
When the Popover is aligned horizontally against the opener,
but it is wider than the opener, the arrows will be centered to the middle of the opener element.

Fixes: #2758
Fixes: #2401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgimkv georgimkv

Labels
bug This issue is a bug in the code Low Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-popup): position arrows correctly
4 participants
@ilhan007 @fifoosid @georgimkv @m-ignatov