-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Input]: [Cannot enter space or Enter when the Input is rendered within the Tree] #7566
Comments
Hi @jamesPodo you have to prevent the I'm not sure if this should be handled by the component itself (since propagation is standard JS event behavior), so I'm transferring this issue to the ui5-webcomponents repo, as the affected components are developed there. Hi colleagues, |
Hello @ui5-webcomponents-topic-rl, Best Regards, |
Hi, the workaround worked for me, but I wonder if this is expected behaviour when the input is rendered in tree list? because it seems the event is being not propagated due to keyboard supports in tree component. Thank you! |
Hello @SAP/ui5-webcomponents-topic-p, The issue is caused by the ListItem which is inherited by the TreeItem. If you look at the _onkeydown method of the component, e.preventDefault(); is called both on SPACE and ENTER key. The issue could be easily reproduced in the CodeSandbox provided, as well as if you enhance the ui5-tree test page by adding a input field within a custom item. Similar issue: #4049 Could you please look over? Kind Regards, |
Some components which extend the ListItem (TreeItemBase) need Space key not to be prevented in order to allow space functionality in some of their nested components. Fixes: SAP#7566
Previously it was impossible to properly use keyboard inside input elements nested in TreeItemCustom. Now the handling is similar to CustomListItem and input elements can be used as expected. Fixes: #7566
Previously it was impossible to properly use keyboard inside input elements nested in TreeItemCustom. Now the handling is similar to CustomListItem and input elements can be used as expected. Fixes: #7566
Describe the bug
cannot type space on input field when the Input is rendered in Tree.
There was a similar issue on Header Input with List.
#4049
Could you please fix the issue? Thank you!
Isolated Example
No response
Reproduction steps
...
Expected Behaviour
No response
Screenshots or Videos
No response
UI5 Web Components for React Version
1.16.0
UI5 Web Components Version
1.14.0
Browser
Chrome
Operating System
Mac
Additional Context
No response
Relevant log output
No response
Declaration
The text was updated successfully, but these errors were encountered: