Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProgressIndicator]: [problem with z-index style when used in scrollable components like ObjectPage] #8303

Closed
1 task done
BloggingWithJan opened this issue Feb 19, 2024 · 2 comments · Fixed by #8797
Closed
1 task done
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@BloggingWithJan
Copy link

Describe the bug

When using a ProgressIndicator in scrollable components like ObjectPage the style z-index of the ProgressIndicator leads to problems

Isolated Example

https://stackblitz.com/edit/github-fxxnbq?file=src%2FApp.tsx

Reproduction steps

  1. Scroll down

Expected Behaviour

The ProgressIndicator is in the background. The ProgressIndicator is not visible/don't overlap the ObjectPageHeader.

Screenshots or Videos

image
image

UI5 Web Components for React Version

"@ui5/webcomponents-react": "~1.25.0",

UI5 Web Components Version

"@ui5/webcomponents": "~1.22.0",

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@BloggingWithJan BloggingWithJan added the bug This issue is a bug in the code label Feb 19, 2024
@Lukas742
Copy link
Collaborator

Hi @BloggingWithJan

you can apply position: relative; z-index: 0; to the ProgressIndicator to prevent this behavior.
But since I assume that this behavior is not intended, I'll transfer the issue to the ui5-webcomponents repo, since the component is developed there.


Hi colleagues,

this issue is similar to #7697.
In my opinion the stacking context should not "escape" the web component, or should at least be customizable. I've created a stackBlitz example to demonstrate the issue without our ObjectPage implementation and I also added internal styles which seem to fix the issue.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Feb 19, 2024
@kskondov kskondov self-assigned this Feb 19, 2024
@kskondov
Copy link
Contributor

Hello, the issue is reproducible in the provided samples, the progress indicator goes over other components when scrolling. @Lukas742 proposed a possible solution @SAP/ui5-webcomponents-topic-p can you please take a look?
Best Regards

@kskondov kskondov removed their assignment Feb 21, 2024
@plamenivanov91 plamenivanov91 self-assigned this Apr 18, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Apr 18, 2024
Removed redundant z-index which causes PI to overlap over some of its
parent elements.

Fixes: SAP#8303
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Apr 18, 2024
Removed redundant z-index which causes PI to overlap over some of its
parent elements.

Fixes: SAP#8303
plamenivanov91 added a commit that referenced this issue Apr 18, 2024
Removed redundant z-index which causes PI to overlap over some of its
parent elements.

Fixes: #8303
plamenivanov91 added a commit that referenced this issue Apr 19, 2024
Removed redundant z-index which causes PI to overlap over some of its
parent elements.

Fixes: #8303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants