Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-dialog]: Small icon when dialog title is too long #8762

Closed
1 task done
kozubikmichal opened this issue Apr 15, 2024 · 1 comment · Fixed by #8839
Closed
1 task done

[ui5-dialog]: Small icon when dialog title is too long #8762

kozubikmichal opened this issue Apr 15, 2024 · 1 comment · Fixed by #8839
Assignees
@dimovpetar
Labels
bug This issue is a bug in the code Medium Prio TOPIC RD

Comments

@kozubikmichal
Copy link

Bug Description

When the dialog title gets truncated because of it's length, the status icon in the dialog header is shrinked

Affected Component

ui5-dialog

Expected Behaviour

Icon stays the same size no matter how long the dialog title is.

Isolated Example

https://stackblitz.com/edit/js-1ndywy?file=index.html

Steps to Reproduce

  1. Open the first dialog with short title - icon size is normal
  2. Open the second dialog with long title - icon is shrinked

Log Output, Stack Trace or Screenshots

image

Priority

None

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@kozubikmichal kozubikmichal added the bug This issue is a bug in the code label Apr 15, 2024
@dimovpetar dimovpetar self-assigned this Apr 15, 2024
@dimovpetar
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rd ,

flex-shrink: 0 on the icon would help here.

Best regards,
Petar

@dimovpetar dimovpetar removed their assignment Apr 15, 2024
@dimovpetar dimovpetar self-assigned this Apr 24, 2024
dimovpetar added a commit that referenced this issue Apr 24, 2024
@dimovpetar
fix(ui5-dialog): state icon no longer shrinks when title is too long
2445820 
Fixes: #8762
@dimovpetar dimovpetar mentioned this issue Apr 24, 2024
Merged
dimovpetar added a commit that referenced this issue Apr 25, 2024
@dimovpetar
fix(ui5-dialog): state icon no longer shrinks when title is too long (#…
9b7fa49 
…8839)

Fixes: #8762
nnaydenow pushed a commit that referenced this issue Apr 29, 2024
@dimovpetar
fix(ui5-dialog): state icon no longer shrinks when title is too long (#…
a3df694 
…8839)

Fixes: #8762
ilhan007 pushed a commit that referenced this issue May 8, 2024
@dimovpetar
fix(ui5-dialog): state icon no longer shrinks when title is too long (#…
06774ea 
…8851)

Fixes: #8762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimovpetar dimovpetar

Labels
bug This issue is a bug in the code Medium Prio TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-dialog): state icon no longer shrinks when title is too long SAP/ui5-webcomponents
2 participants
@kozubikmichal @dimovpetar