Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-combobox-item: getDomRef() returns undefined #8841

Closed
1 task done
Lukas742 opened this issue Apr 24, 2024 · 2 comments · Fixed by #8872
Closed
1 task done

ui5-combobox-item: getDomRef() returns undefined #8841

Lukas742 opened this issue Apr 24, 2024 · 2 comments · Fixed by #8872
Assignees
Labels
bug This issue is a bug in the code consulting Medium Prio TOPIC RL

Comments

@Lukas742
Copy link
Collaborator

Bug Description

When calling the getDomRef method of an ComboBoxItem, it doesn't return the element inside the shadow root, but undefined.

Affected Component

ComboBoxItem

Expected Behaviour

No response

Isolated Example

https://stackblitz.com/edit/js-k4ebjr?file=index.js,index.html

Steps to Reproduce

  1. Go to StackBlitz
  2. Click on the "Log getDomRef()" button
  3. See that only for the MultiComboBoxItem the correct value is returned

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742 Lukas742 added the bug This issue is a bug in the code label Apr 24, 2024
@NHristov-sap
Copy link
Contributor

Hello @ui5-webcomponents-topic-rl,

Can you please check if the abstract ComboBoxItem should have DOM ref or not. If it should, please check why it is undefined.

Best Regards,
Nikolay Hristov
UI5 WebComponents Dispatcher

@Lukas742
Copy link
Collaborator Author

Hi @NHristov-sap

thanks for processing this issue.
According to your docs, getDomRef should return the element that represents the abstract component:

Note: For logical (abstract) elements (items, options, etc...), returns the part of the parent's DOM that represents this option

@ndeshev ndeshev self-assigned this Apr 26, 2024
ndeshev added a commit that referenced this issue May 8, 2024
* fix(ui5-cb-item): return the DOM reference of the list item

fixes: #8841
LidiyaGeorgieva pushed a commit that referenced this issue May 9, 2024
* fix(ui5-cb-item): return the DOM reference of the list item

fixes: #8841
ndeshev added a commit that referenced this issue May 13, 2024
* fix(ui5-cb-item): return the DOM reference of the list item (#8872)

fixes: #8841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code consulting Medium Prio TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants