Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF_ACC][FileUploader]: Input is skipped in the reverse tabbing order in the dialog #9090

Closed
1 task done
ksblklu02 opened this issue May 30, 2024 · 1 comment · Fixed by #9162
Closed
1 task done
Assignees
Labels

Comments

@ksblklu02
Copy link

ksblklu02 commented May 30, 2024

Bug Description

With JAWS, When user navigate with Tab key on all the input field until reaching Cancel button -> After press Shift+Tab and continue tabbing until reaching the FileUploader Input Upon pressing the Shift+Tab key again -> Observe that the focus skips the input field, resulting in an incorrect tab order.

Affected Component

ui5-file-uploader

Expected Behaviour

The tabbing order defined on the page is logical and tab order should not get trapped, Also user should be able to tab through the entire page and shift+tab back in the same reverse order.

Isolated Example

https://stackblitz.com/edit/github-utmbsj?file=src%2FApp.tsx

Steps to Reproduce

  1. Go to https://stackblitz.com/edit/github-utmbsj?file=src%2FApp.tsx
  2. Click"open dialog" button
  3. Tabbing to the cancel button, and then use Shift + Tab reverse tab to the FileUploader component
  4. See the FileUploader input was skipped in reverse tabbing order

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.24.0

Browser

Chrome

Operating System

Mac OS

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@ksblklu02 ksblklu02 added the bug This issue is a bug in the code label May 30, 2024
@ksblklu02 ksblklu02 changed the title [SF][FileUploader]: Input is skipped in the reverse tabbing order in the dialog [SF_ACC][FileUploader]: Input is skipped in the reverse tabbing order in the dialog May 30, 2024
@niyap niyap self-assigned this Jun 3, 2024
@niyap
Copy link
Contributor

niyap commented Jun 3, 2024

Hello @SAP/ui5-webcomponents-topic-b,

When ui5-file-uploader without button but just an input field is placed within a dialog as a first element, it receives focus which I think is not expected, as it does not receive focus in any other use case. On backward navigation the same component is not focused.
Here is a sample: Playground

The issue can be reproduced in the provided StackBlitz sample as well.

Could you please check?

Thank you in advance!

Kind Regards,
Niya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants