Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(framework): Create a localization package and deprecate utils #1296

Merged
merged 6 commits into from
Mar 13, 2020

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Mar 13, 2020

  • utils deprecated in favor of localization
  • localization now uses nps like the other packages, has lint and watch and is properly integrated within the project's lifecycle
  • localization now depends on tools as a devDependency for the purposes of sharing eslint configuration
  • localization only builds if the dist/ directory does not exist (again), but it has a watch task which allows to easily work with the src/ directory
  • localization no longer copies the sap_belize fonts for the purposes of the playground, the playground has these files anyway
  • the used-modules.txt file now supports full-line comments with #
  • the base package had a leftover task to copy CLDRs which is now deleted

@vladitasev vladitasev merged commit b5e1337 into master Mar 13, 2020
@vladitasev vladitasev deleted the localization-package branch March 13, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants