fix(ui5-daterange-picker): show value in input only when first & last… #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
requested changes
Aug 19, 2020
vladitasev
requested changes
Sep 21, 2020
vladitasev
previously approved these changes
Sep 21, 2020
vladitasev
approved these changes
Sep 24, 2020
ilhan007
pushed a commit
that referenced
this pull request
Oct 17, 2020
ilhan007
pushed a commit
that referenced
this pull request
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1988
The main idea of this change is to split the value property into two separate properties
The only state that they are not in sync is when only one date is selected. Otherwise they have the same value.