Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-select): improve accessibility #2239

Closed
wants to merge 2 commits into from
Closed

fix(ui5-select): improve accessibility #2239

wants to merge 2 commits into from

Conversation

nnaydenow
Copy link
Contributor

Removed overwriting aria-label value by aria-labelledby.

#2142

@@ -29,6 +28,8 @@
dir="{{effectiveDir}}"
></ui5-icon>

<span id="{{_id}}-labelText" class="ui5-hidden-text">{{ariaLabelText}} {{_text}}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be more correct if the aria-labelledby point to both the _text span and the ariaLabelText coming from the component

example aria-labelledby="{{_id}}-labelText {{_id}}-label"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants