Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: register runtime in SSR usage (#9013) #9014

Merged
merged 3 commits into from
May 21, 2024
Merged

fix: register runtime in SSR usage (#9013) #9014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cf0a31
fix: register runtime in SSR usage (#9013)
pskelin May 21, 2024
4e1977d
chore: update chromedriver
pskelin May 21, 2024
59b561d
Merge branch 'release-1.24' into ssr-fix-1-24
pskelin May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"devDependencies": {
"@openui5/sap.ui.core": "1.120.5",
"@ui5/webcomponents-tools": "1.24.3",
"chromedriver": "^123.0.3",
"chromedriver": "^124.0.4",
"clean-css": "^5.2.2",
"copy-and-watch": "^0.1.5",
"cross-env": "^7.0.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/base/src/Boot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@ const boot = async (): Promise<void> => {
}

const bootExecutor = async (resolve: PromiseResolve) => {
registerCurrentRuntime();

if (typeof document === "undefined") {
resolve();
return;
}

attachThemeRegistered(onThemeRegistered);

registerCurrentRuntime();

const openUI5Support = getFeature<typeof OpenUI5Support>("OpenUI5Support");
const isOpenUI5Loaded = openUI5Support ? openUI5Support.isOpenUI5Detected() : false;
const f6Navigation = getFeature<typeof F6Navigation>("F6Navigation");
Expand Down
2 changes: 1 addition & 1 deletion packages/fiori/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@
},
"devDependencies": {
"@ui5/webcomponents-tools": "1.24.3",
"chromedriver": "^123.0.3"
"chromedriver": "^124.0.4"
}
}
2 changes: 1 addition & 1 deletion packages/localization/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@openui5/sap.ui.core": "1.120.5",
"@ui5/webcomponents-tools": "1.24.3",
"babel-plugin-amd-to-esm": "^2.0.3",
"chromedriver": "^123.0.3",
"chromedriver": "^124.0.4",
"estree-walk": "^2.2.0",
"mkdirp": "^1.0.4",
"resolve": "^1.20.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/main/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@
},
"devDependencies": {
"@ui5/webcomponents-tools": "1.24.3",
"chromedriver": "^123.0.3"
"chromedriver": "^124.0.4"
}
}