Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render SVG content with lit svg` #904

Merged
merged 11 commits into from
Nov 15, 2019
Merged

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Oct 31, 2019

Background

The SVG tag itself should be rendered with the html function, but its content must be rendered with the svg function of lit-html. Otherwise dynamic updates inside the svg do not work.

Othe changes

ui5-icon

  • Create Icon HBS template and remove the IconLitTemplate as it will be generated properly

ui5-shellbar

  • Update ShellBar`s CoPilot animates (taken from latest openui5)
  • Make ShellBar`s animated CoPilot add-on feature, by default the CoPilot is displayed as static SVG .
    To make it animated you have the following public import:
import "@ui5/webcomponents/dist/features/CoPilotAnimation.js":
  • Start considering the global animationMode config regarding the CoPilot animation

BREAKING CHANGE: to get the ShellBar's coPilot animated you have to import the @ui5/webcomponents/dist/features/CoPilotAnimation.js module

@ilhan007 ilhan007 requested a review from pskelin October 31, 2019 12:54
pskelin
pskelin previously approved these changes Oct 31, 2019
@ilhan007 ilhan007 dismissed pskelin’s stale review October 31, 2019 14:32

the animation transforms does not work properly as they should be added with svg, not html

@ilhan007 ilhan007 changed the title refactor(ui5-shellbar): extract animated coPilot as add-on feat feat: render SVG content with lit svg` Nov 12, 2019
@ilhan007 ilhan007 merged commit 59fead4 into master Nov 15, 2019
@ilhan007 ilhan007 deleted the extract-shellbar-copilot branch November 15, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants