-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render SVG content with lit svg` #904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskelin
reviewed
Oct 31, 2019
pskelin
previously approved these changes
Oct 31, 2019
ilhan007
dismissed
pskelin’s stale review
October 31, 2019 14:32
the animation transforms does not work properly as they should be added with svg, not
html
3 tasks
ilhan007
changed the title
refactor(ui5-shellbar): extract animated coPilot as add-on feat
feat: render SVG content with lit svg`
Nov 12, 2019
vladitasev
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The SVG tag itself should be rendered with the html function, but its content must be rendered with the svg function of lit-html. Otherwise dynamic updates inside the svg do not work.
Othe changes
ui5-icon
ui5-shellbar
To make it animated you have the following public import:
animationMode
config regarding the CoPilot animationBREAKING CHANGE: to get the ShellBar's coPilot animated you have to import the
@ui5/webcomponents/dist/features/CoPilotAnimation.js
module