Match Interactable 086 #74
Conversation
Co-authored-by: Oliver Bell <freshollie@gmail.com>
Co-authored-by: Oliver Bell <freshollie@gmail.com>
| @@ -26,7 +26,7 @@ typedef struct { | |||
| } Sprite_NoteParticle; /* size: 0x4C */ | |||
|
|
|||
| /* {anim, variant, tileCount, shouldAllocTileMem(?), (unk | priority)} */ | |||
| static const u16 gUnknown_080E0140[4][5] = { | |||
| static const ALIGNED(4) u16 gUnknown_080E0140[4][5] = { | |||
There was a problem hiding this comment.
Yes, since there's 2 zero-bytes that are removed without explicitly aligning it.
Alternatively I could add 0s to the previous array, but then we wouldn't be able to use ARRAY_COUNT with it.
There was a problem hiding this comment.
In my head, this shows it should be a struct array? As I think struct arrays align 4?
There was a problem hiding this comment.
Well, using a struct sadly doesn't match.
| { 8, 32 }, | ||
| { 16, 32 }, | ||
| { 32, 64 }, | ||
| }; | ||
|
|
||
| void sub_80051E8(Sprite *sprite) |
There was a problem hiding this comment.
So this is like ApplyEffects?
There was a problem hiding this comment.
That name's too general for a global procedure.
Also, I don't think "effects" is right? How did you infer that name?
There was a problem hiding this comment.
I'm not saying that should be the name. This functions is generally called with the sprite RenderAnimationFrame function call.
Maybe you are right that it's not effects. When I say effects I am referring to unk10 which is like a flag of effects which apply to the sprite (though this could also be flags) when this function is called the OamData of the sprite is updated with the result of effects currently applied to the sprite? rotation etc?
There was a problem hiding this comment.
I see.
Well it rather is "attributes" than anything else. OAM is part of the GBA and DS, as well as some other platforms iirc,, so for this, maybe ConvertSpriteFlagsToOamAttributes/ToOamData. Maybe a little shorter than that! :D
There was a problem hiding this comment.
Is it not Sprite_ApplyOamAttributes(...)
|
|
||
| gCurTask->main = Task_807D0C4; | ||
| } | ||
| #else |
There was a problem hiding this comment.
I think my changes were undone from last night. You should remove the NON_MATCHING blocks from this second function
| /* 0x20 */ u16 quarterWidth; | ||
|
|
||
| // unused | ||
| /* 0x22 */ u8 padding22[2]; |
There was a problem hiding this comment.
You should be able to delete this. The pointer after this will align to 4
There was a problem hiding this comment.
Yeah already tried that before, without issue.
Just wasn't sure whether we want to keep padding for documentation purposes or not! :D
No description provided.