Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a node parameter to select header.stamp source and computation method #48

Closed
rsiryani opened this issue Aug 20, 2021 · 0 comments
Closed
Assignees
Milestone

Comments

@rsiryani
Copy link
Contributor

rsiryani commented Aug 20, 2021

In the current implementation header.stamp is based on message processing ROS time unless a valid UTC time message is received.
We should simplify this and let the user choose which time reference he would like.

We should add a node parameter to either select:

  • ROS only processing time (ros)
  • INS absolute time referenced to UNIX epoch (ins_unix)
  • INS absolute time referenced to GPS (ins_gps) - later
  • INS absolute time referenced to UTC (ins_utc) - later

If we don't have yet a valid GPS/UTC time we should fallback to ROS system time.

ROS time is a large topic and any feedback from the community would be appreciated.

@rsiryani rsiryani added this to the Rework Time milestone Aug 20, 2021
@rsiryani rsiryani added this to To do in Revamped ROS driver via automation Aug 20, 2021
@bsaussay bsaussay moved this from To do to In Progress in Revamped ROS driver Aug 26, 2021
bsaussay pushed a commit that referenced this issue Aug 26, 2021
bsaussay pushed a commit that referenced this issue Aug 26, 2021
@bsaussay bsaussay linked a pull request Aug 26, 2021 that will close this issue
@bsaussay bsaussay moved this from In Progress to Done in Revamped ROS driver Aug 26, 2021
@bsaussay bsaussay assigned bsaussay and unassigned mzembsbg Aug 26, 2021
bsaussay pushed a commit that referenced this issue Aug 27, 2021
@bsaussay bsaussay linked a pull request Aug 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment