Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all standard ROS messages to use ENU frame #50

Closed
rsiryani opened this issue Aug 23, 2021 · 2 comments
Closed

Update all standard ROS messages to use ENU frame #50

rsiryani opened this issue Aug 23, 2021 · 2 comments
Assignees
@bsaussay
Labels
enhancement

Comments

@rsiryani
Copy link
Contributor

All published standard ROS messages should comply with frame convention that is ENU.
The following link describe the accepted ROS conventions:
https://www.ros.org/reps/rep-0103.html
@rsiryani
Copy link
Contributor Author

According to https://www.ros.org/reps/rep-0145.html
And to avoid breaking current users' implementation, we should have an option to either output using enu or ned.
We should make sure we also comply with the frame_id convention imu_link_ned / imu_link

@bsaussay bsaussay assigned bsaussay and unassigned mzembsbg Aug 26, 2021
bsaussay pushed a commit that referenced this issue Aug 27, 2021
#45-#50 - Add parameters to set frame ID and ENU convention
ffc9af6
@bsaussay bsaussay linked a pull request Aug 27, 2021 that will close this issue
Rework ros driver #58
Closed
@mzembsbg
Copy link
Contributor

mzembsbg commented Sep 1, 2021

Done with PR #62

@mzembsbg mzembsbg closed this as completed Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsaussay bsaussay

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework ros driver SBG-Systems/sbg_ros_driver
3 participants
@rsiryani @bsaussay @mzembsbg