Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a choice of slide backend: openslide and tiffslide #136

Closed
kaczmarj opened this issue Jul 7, 2023 · 2 comments · Fixed by #144
Closed

add a choice of slide backend: openslide and tiffslide #136

kaczmarj opened this issue Jul 7, 2023 · 2 comments · Fixed by #144

Comments

@kaczmarj
Copy link
Member

kaczmarj commented Jul 7, 2023

replace openslide with tiffslide https://github.com/bayer-science-for-a-better-life/tiffslide

tiffslide is implemented in pure python and should make distribution easier.

@kaczmarj
Copy link
Member Author

kaczmarj commented Jul 7, 2023

let's wait to incorporate tiffslide until Bayer-Group/tiffslide#72 is resolved. i have found that tiffslide is slower than openslide when reading patches from a TCGA BRCA slide.

@kaczmarj
Copy link
Member Author

instead of removing openslide, we have included a choice of backend, tiffslide or openslide in #139

this will require uses to install openslide or tiffslide separately. let's think about how to do this... what should be listed as a required dependency in setup.py?

@kaczmarj kaczmarj changed the title replace openslide with tiffslide add a choice of slide backend: openslide and tiffslide Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant