fix input of "rawlist" #1089
Merged
fix input of "rawlist" #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug where using arrow keys and then entering a specific choice via index would cause an "invalid response" error
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 4 4
Lines 171 171
Branches 23 23
=======================================
Hits 151 151
Misses 1 1
Partials 19 19 Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the input processing of "rawlist". To reproduce the bug:
Because the arrow keys record the selected index on the input line, when the user enters a specific index, an ultimately invalid index is processed by the code.
This works around that by not using the input line to record the selected index when using arrow keys. Instead it records the selected index in a private variable.