feat(prompt): progress indicator for filter and validate with optional message #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrandwijk
force-pushed
the
feature/progress
branch
from
29c4987
to
7bdebb8
Compare
|
It seems Codacy and the XO settings don't agree... |
kbrandwijk
force-pushed
the
feature/progress
branch
from
0cb473f
to
6019bf6
Compare
kbrandwijk
force-pushed
the
feature/progress
branch
from
5082579
to
6731923
Compare
|
any reason this can't be merged? @kbrandwijk |
|
@kbrandwijk I removed Codacy as its supports for eslint config is too flakey. It kept starting to mark PR as failing every few months. I'd love to get this merged. Any chance you could resolve the conflicts and try to finalize the integration? |
|
Don't suppose you have any updates on this @kbrandwijk? This would be incredibly useful to have! |
|
This was merged via #1002 - so this can now be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - First proposal for adding progress indicator to filter and validate step, with an optional message to be displayed during these steps. Includes an example. Will update tests and docs after initial review.
Closes #631