removed shading when less than 3 forecasts #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 54.95% 54.95%
=======================================
Files 23 23
Lines 3963 3963
Branches 578 578
=======================================
Hits 2178 2178
Misses 1648 1648
Partials 137 137 ☔ View full report in Codecov by Sentry. |
fabiolsilva
approved these changes
Nov 29, 2023
| @@ -1769,8 +1769,9 @@ def plot_comparison_test(results_t, results_w=None, axes=None, plot_args=None): | |||
| ax.yaxis.set_major_locator(matplotlib.ticker.MaxNLocator(integer=True)) | |||
| ax.set_ylim([ylim[0], ylim[1]]) | |||
| ax.set_xlim([-0.5, len(results_t) - 0.5]) | |||
| ax.bar(xTickPos, numpy.array([9999] * len(xTickPos)), bottom=-2000, | |||
| width=(xTickPos[1] - xTickPos[0]), color=['gray', 'w'], alpha=0.2) | |||
| if len(results_t) > 2: | |||
There was a problem hiding this comment.
Only add shading when we have more than 2 forecasts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #214