Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not Running with Python <3.6 #52

Closed
patrickmelix opened this issue Jan 21, 2019 · 4 comments
Closed

Not Running with Python <3.6 #52

patrickmelix opened this issue Jan 21, 2019 · 4 comments

Comments

@patrickmelix
Copy link
Collaborator

patrickmelix commented Jan 21, 2019 •
edited
Loading

Line 22 in plams/interfaces/molecule/rdkit.py uses ModuleNotFoundError which is only added in Python 3.6. Therefore PLAMS cannot run with any version lower than that.
Edit: Seems like it pops up in more than one place....

This is bad since many users are restricted to the Python Version from the OS.
@patrickmelix
Copy link
Collaborator Author

Workaround: Replace all by ImportError

@h4nsu
Copy link
Contributor

h4nsu commented Jan 21, 2019

Meeeeh, backwards compatibility is soooo overrated ;) Besides that, Python 3.6 was released in December 2016...

Ok, I'll fix it :P

@patrickmelix
Copy link
Collaborator Author

patrickmelix commented Jan 23, 2019 •
edited
Loading

If it would have been a killer feature, I would have upgraded. But for an ImportError?! Nope 😜

Thanks!

h4nsu added a commit that referenced this issue Jan 25, 2019
@h4nsu
Change import errors to work with Python<3.6 #52
9995865
@h4nsu
Copy link
Contributor

h4nsu commented Jan 25, 2019

Viola!

@h4nsu h4nsu closed this as completed Jan 25, 2019
@patrickmelix patrickmelix mentioned this issue Feb 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@h4nsu @patrickmelix