removed all the unused block_replace functionality #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
- Coverage 81.37% 81.24% -0.13%
==========================================
Files 39 39
Lines 1906 1893 -13
Branches 241 237 -4
==========================================
- Hits 1551 1538 -13
Misses 281 281
Partials 74 74
Continue to review full report at Codecov.
|
BvB93
reviewed
Nov 12, 2020
There was a problem hiding this comment.
By the looks it there are still a few more references to this, now redundant, __block_replace key:
https://github.com/search?q=org%3ASCM-NV+__block_replace&type=code
This was referenced Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
__block_replacefunctionalityxcsection from the ADF template