Use snprintf in tests #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bobpaw
commented
Jun 21, 2024
bobpaw
commented
- I missed some sprintf calls before. I don't see any others (find + grep).
- These deprecation errors come up with LLVM so others might not notice.
- I missed some sprintf calls before. This should be all of them? - These deprecation errors come up with LLVM so others might not notice. Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
- Found two more lingering files with sprintf calls. Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
|
/runtests |
|
Test Result: failure (details) |
Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
cwsmith
approved these changes
Jun 21, 2024
flagdanger
pushed a commit
to flagdanger/core
that referenced
this pull request
Aug 6, 2024
* fix: Replace sprintf with snprintf in tests - I missed some sprintf calls before. This should be all of them? - These deprecation errors come up with LLVM so others might not notice. Signed-off-by: Aiden Woodruff <woodra@rpi.edu> * fix: Replace sprintf with snprintf - Found two more lingering files with sprintf calls. Signed-off-by: Aiden Woodruff <woodra@rpi.edu> * Fix one snprintf size Signed-off-by: Aiden Woodruff <woodra@rpi.edu> --------- Signed-off-by: Aiden Woodruff <woodra@rpi.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.