Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setup_fastf1 to only help with install. #190

Merged
merged 13 commits into from
Oct 2, 2023

Conversation

pbulsink
Copy link
Collaborator

@pbulsink pbulsink commented Oct 2, 2023

Per #187

@pbulsink pbulsink linked an issue Oct 2, 2023 that may be closed by this pull request
@pbulsink
Copy link
Collaborator Author

pbulsink commented Oct 2, 2023

Still doesn't work on GH Actions. It's certainly because of the reticulate 1.32.0 update

The reticulate docs use r-tensorflow as example - and even it doesn't test the environment handling, but they do test lots of other stuff.

So, @SCasanova should we remove the test from the list?

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #190 (fa986c4) into master (fdfcc52) will increase coverage by 0.52%.
Report is 2 commits behind head on master.
The diff coverage is 50.00%.

❗ Current head fa986c4 differs from pull request most recent head 5554b66. Consider uploading reports for the commit 5554b66 to get more accurate results

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   92.66%   93.19%   +0.52%     
==========================================
  Files          18       18              
  Lines         641      617      -24     
==========================================
- Hits          594      575      -19     
+ Misses         47       42       -5     
Files Coverage Δ
R/zzz.R 26.31% <ø> (ø)
R/utils.R 77.19% <50.00%> (-0.59%) ⬇️

@SCasanova
Copy link
Owner

Still doesn't work on GH Actions. It's certainly because of the reticulate 1.32.0 update

The reticulate docs use r-tensorflow as example - and even it doesn't test the environment handling, but they do test lots of other stuff.

So, @SCasanova should we remove the test from the list?

Hmm maybe. If that's their practice then it's not bad to follow. Especially now that it's causing issues

pbulsink and others added 4 commits October 2, 2023 10:37
Per https://community.rstudio.com/t/new-r-cmd-check-note-in-r-4-2-0-for-imports-field/143153/3, the note comes because the functions janitor, tibble and tidyr are all used in functions built in `.onLoad` and not *actually* used in production code.
@pbulsink pbulsink merged commit e5ffb2b into SCasanova:master Oct 2, 2023
@pbulsink pbulsink deleted the dev branch October 2, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH Actions R CMD Chk Failures
2 participants