Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update refresh #37

Merged
merged 11 commits into from
Jan 9, 2019
Merged

Update refresh #37

merged 11 commits into from
Jan 9, 2019

Conversation

akench
Copy link
Collaborator

@akench akench commented Jan 6, 2019

switched from swipe refresh layout to refresh button on toolbar (for site pages)

Copy link
Owner

@SChakravorti21 SChakravorti21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, I just added a couple notes on LiveData observations since we want to do them in a safe way.

@akench akench merged commit 866e366 into master Jan 9, 2019
@akench akench deleted the update-refresh branch January 9, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants