Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to sbol2 #49

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Convert to sbol2 #49

merged 3 commits into from
Jun 18, 2020

Conversation

tcmitchell
Copy link

Change SYNBICT to use pySBOL2.

This was primarily an update to exception handling to be compatible with both pySBOL and pySBOL2. Other than that it was updates to import statements and to setup.py as would be expected.

Fixes #48
Fixes #46

This change serves as backward and forward compatible with pySBOL swig
and native pySBOL. It also serves as better documentation about what
the raised error means, and why the code responds the way it does.
@tcmitchell tcmitchell requested a review from nroehner June 5, 2020 15:11
@tcmitchell tcmitchell changed the base branch from master to develop June 5, 2020 15:12
@nroehner nroehner merged commit d4f9174 into develop Jun 18, 2020
@tcmitchell tcmitchell mentioned this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to pySBOL2 Be dynamic about raised exceptions for object not found
2 participants