Add missing includes to configure script #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for gcc 14 and clang 16 as they both make implicit function definitions a hard error. In a configure script, this means these tests will switch from passing to failing, which likely means features will get unintentionally flipped as configure now thinks you don't have support. See: https://wiki.gentoo.org/wiki/Modern_C_porting See: https://bugs.gentoo.org/931607
matoro
requested review from
Fish-Git,
ivan-w,
Juergen-Git and
Peter-J-Jansen
as code owners
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
May 17, 2024
Touching just configure.ac is fine as we call eautoreconf in ebuild. See: SDL-Hercules-390/hyperion#658 Closes: https://bugs.gentoo.org/931607 Closes: https://bugs.gentoo.org/931610 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
4 tasks
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 6, 2024
Touching just configure.ac is fine as we call eautoreconf in ebuild. See: SDL-Hercules-390/hyperion#658 Closes: https://bugs.gentoo.org/931607 Closes: https://bugs.gentoo.org/931610 Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk> Closes: #36724 Signed-off-by: Mike Gilbert <floppym@gentoo.org>
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for gcc 14 and clang 16 as they both make implicit function definitions a hard error. In a configure script, this means these tests will switch from passing to failing, which likely means features will get unintentionally flipped as configure now thinks you don't have support.
See: https://wiki.gentoo.org/wiki/Modern_C_porting
See: https://bugs.gentoo.org/931607