-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple font styles in var names #444
Allow multiple font styles in var names #444
Conversation
I should have upgraded my environment before pushing any changes 😅. At some point we should look at the breaking changes from numpy 2.0 |
Hi @rogersamso Thank you for taking care of this, I would try to filter the numpy warning before limiting the version, I am doing some tests locally and I will let you know. |
Filtering the warning here seems to work Lines 71 to 73 in d1263fb
|
Do I delete the last commit, then? |
Yes, you can delete the last two, no need to limit more the version of openpyxl Also need to do a small change in the builder pysd/pysd/builders/python/subscripts.py Lines 310 to 311 in 3ce331c
|
Sorry there is something that still fails |
openpyxl 3.1.1 breaks things |
Okay! |
It seems that it is working now. You can remove the last commit, and I will merge the fixes to the test in the master. I will also make CI skip the coverage for Windows and Python 3.12, so it will run faster |
6d3b060
to
2df015b
Compare
Done |
Description
When parsing the sketch, multiple font styles may be used for variable names. Before this PR only a single style option was possible.
Related issues
Fixes #443
Type of change
PR verification (to be filled by reviewers)