-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DB forum post schema. #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
Howevr, I don't think the model directory is the correct place for a schema.
Could you move the schema to config and maybe make a new subdirectory for schemas?
You can manually test that it works, and someone should be self- or peer-reviewing the code before the code review.
subdir in config
Added unit test for forum post schema.
@R055A The changes you requested have been made. Could you please re-review it? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be a good idea to include date and time. The test passes.
@R055A timestamps have been added for date-time attributes. It will assign createdAt and updatedAt fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Added a database schema for a forum post using mongoose.
This should be used when a new forum post is created.
Related Issue
Solves #33
Type of change
How Has This Been Tested?
This schema has not been tested.
Checklist:
For more information, refer to the Contributing Guidelines document.