Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature for Forum post search #48

Merged
merged 5 commits into from
Mar 17, 2022
Merged

add feature for Forum post search #48

merged 5 commits into from
Mar 17, 2022

Conversation

AlexMiao7
Copy link
Contributor

@AlexMiao7 AlexMiao7 commented Mar 17, 2022 •
edited
Loading

Description

Related Issue

Solves #

Type of change

  • New feature (enhancement)
  • Bug fix
  • Refactor
  • Breaking change
  • Documentation

How Has This Been Tested?

  • Automated testing
  • Manual testing

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Does the code build without new warnings?
  • Has testing been performed that proves changes are effective and work?
  • Has a self- and/or peer-review of the code been performed?
  • Have dependent changes been merged and published in downstream modules?
  • Does all new and existing automated testing pass?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines document.

@AlexMiao7 AlexMiao7 requested a review from a team as a code owner March 17, 2022 03:20
@AlexMiao7 AlexMiao7 added this to the Assignment 1 milestone Mar 17, 2022
@AlexMiao7 AlexMiao7 linked an issue Mar 17, 2022 that may be closed by this pull request
Implement search request for forum post comment #28
Closed
@AlexMiao7 AlexMiao7 removed a link to an issue Mar 17, 2022
Implement search request for forum post comment #28
Closed
@AlexMiao7 AlexMiao7 linked an issue Mar 17, 2022 that may be closed by this pull request
Implement search request for forum post #24
Closed
@kimslor
Copy link
Contributor

kimslor commented Mar 17, 2022

Could you add a link in the PR description on what issue this PR is associated with, thanks.

@R055A R055A self-requested a review March 17, 2022 03:55
@R055A R055A self-assigned this Mar 17, 2022
@R055A R055A added the enhancement New feature or request label Mar 17, 2022
R055A
R055A approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@R055A R055A left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @AlexMiao7 !

Are the successful tests for user search dependent on the IDs being searched for being manually inserted into the database?

@R055A R055A merged commit 7fd9b83 into SE701-T5:main Mar 17, 2022
@AlexMiao7 AlexMiao7 deleted the forum_search branch March 18, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R055A R055A R055A approved these changes

Assignees

@R055A R055A

Labels
enhancement New feature or request
Projects
None yet
Milestone
Assignment 1
Development

Successfully merging this pull request may close these issues.

Implement search request for forum post
3 participants
@AlexMiao7 @kimslor @R055A