Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user authentication #68

Merged
merged 10 commits into from
Mar 20, 2022
Merged

Implement user authentication #68

merged 10 commits into from
Mar 20, 2022

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Mar 19, 2022

Description

Implement user authentication

  • add authorization verification to existing features for logged-in users
  • add user login feature
  • add authorization verification to API gateway
  • add test cases for user authentication
  • apply user authentication changes to existing test cases
  • add authorization token to user schema
  • add missing documentation, improve existing documentation
  • improve configuration

gnerating authorization token hex strings is resourced from how-to-generate-random-hex-string-in-javascript

Related Issue

Solves #21

Type of change

  • New feature (enhancement)

How Has This Been Tested?

Multiple new test cases for testing user authentication and changes for user authentication applied to more existing test cases

  • Automated testing

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Does the code build without new warnings?
  • Has testing been performed that proves changes are effective and work?
  • Has a self- and/or peer-review of the code been performed?
  • Does all new and existing automated testing pass?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.

add authorization verification to existing features for logged-in users
add user login feature
add authorization verification to API gateway
add test cases for user authentication
apply user authentication changes to existing test cases
add authorization token to user schema
add missing documentation, improve existing documentation
improve configuration
@R055A R055A added the enhancement New feature or request label Mar 19, 2022
@R055A R055A added this to the Assignment 1 milestone Mar 19, 2022
@R055A R055A requested a review from a team as a code owner March 19, 2022 17:11
@R055A R055A self-assigned this Mar 19, 2022
@R055A R055A linked an issue Mar 19, 2022 that may be closed by this pull request
controllers/forum.server.controller.js Show resolved Hide resolved
controllers/user.server.controller.js Show resolved Hide resolved
test/authenticate.user.test.js Show resolved Hide resolved
test/authenticate.user.test.js Show resolved Hide resolved
test/authenticate.user.test.js Show resolved Hide resolved
test/authenticate.user.test.js Outdated Show resolved Hide resolved
test/authenticate.user.test.js Outdated Show resolved Hide resolved
test/user.test.js Show resolved Hide resolved
R055A and others added 2 commits March 20, 2022 13:40
Co-authored-by: Kimsong <68843643+kimslor@users.noreply.github.com>
Co-authored-by: Kimsong <68843643+kimslor@users.noreply.github.com>
@R055A R055A requested a review from kimslor March 20, 2022 00:43
kimslor
kimslor previously approved these changes Mar 20, 2022
Copy link
Contributor

@kimslor kimslor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting changes.

test/authenticate.user.test.js Outdated Show resolved Hide resolved
test/authenticate.user.test.js Outdated Show resolved Hide resolved
test/authenticate.user.test.js Outdated Show resolved Hide resolved
test/authenticate.user.test.js Outdated Show resolved Hide resolved
test/authenticate.user.test.js Outdated Show resolved Hide resolved
test/authenticate.user.test.js Outdated Show resolved Hide resolved
test/authenticate.user.test.js Outdated Show resolved Hide resolved
Co-authored-by: Kimsong <68843643+kimslor@users.noreply.github.com>
R055A and others added 6 commits March 20, 2022 13:58
Co-authored-by: Kimsong <68843643+kimslor@users.noreply.github.com>
Co-authored-by: Kimsong <68843643+kimslor@users.noreply.github.com>
Co-authored-by: Kimsong <68843643+kimslor@users.noreply.github.com>
Co-authored-by: Kimsong <68843643+kimslor@users.noreply.github.com>
Co-authored-by: Kimsong <68843643+kimslor@users.noreply.github.com>
Co-authored-by: Kimsong <68843643+kimslor@users.noreply.github.com>
@R055A R055A requested a review from kimslor March 20, 2022 01:33
@R055A R055A merged commit ce833f7 into SE701-T5:main Mar 20, 2022
@R055A R055A deleted the user-authenticate branch March 20, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement user authentication
2 participants