Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test suite setup and teardown #73

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Refactor test suite setup and teardown #73

merged 1 commit into from
Mar 20, 2022

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Mar 20, 2022

Description

Refatctored the setup and teardown for all test suites accessing the database.

Observed total local test performance time is optimized with a total time of ~15% of the unoptimized total test time.

Related Issue

Solves #72

Type of change

  • Refactor

How Has This Been Tested?

It is a refactor of existing test suites and all existing testing passes after the refactor.

  • Automated testing

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Does the code build without new warnings?
  • Has testing been performed that proves changes are effective and work?
  • Has a self- and/or peer-review of the code been performed?
  • Does all new and existing automated testing pass?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.

for optimal total test performance time
@R055A R055A added the enhancement New feature or request label Mar 20, 2022
@R055A R055A added this to the Assignment 1 milestone Mar 20, 2022
@R055A R055A requested a review from a team as a code owner March 20, 2022 05:00
@R055A R055A self-assigned this Mar 20, 2022
@R055A R055A linked an issue Mar 20, 2022 that may be closed by this pull request
@R055A R055A merged commit 5148620 into SE701-T5:main Mar 20, 2022
@R055A R055A deleted the fix-test-before branch March 20, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Test Suite Setup and Teardown
2 participants