Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main repo for demonstration #76

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Fix main repo for demonstration #76

merged 1 commit into from
Mar 20, 2022

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Mar 20, 2022

Description

The most recent merge caused the CI to fail. This is although the CI for the pull request passed. There was no indication in the pull request that the merge was going to fail. It can be assumed the merge bug that unnoticed without code conflict. The merge conflict is between old and new pull requests.

However, the issue now seems to be resolved with all test cases passing when run locally.

Tasks completed:

  • Fix user logout test cases
  • Fix CI workflow for fork repos
  • Fix missing doc

Related Issue

Solves #75

Type of change

  • Bug fix

How Has This Been Tested?

Fixes to failing tests have been completed so all tests are passing

  • Automated testing

Checklist:

  • Does a similar (open or closed) pull request not already exist?
  • Is the pull request head repository a fork repository?
  • Is the pull request compare branch a development branch?
  • Is the code documented, particularly in hard-to-understand areas?
  • Does the code build without new warnings?
  • Has testing been performed that proves changes are effective and work?
  • Has a self- and/or peer-review of the code been performed?
  • Does all new and existing automated testing pass?
  • Is the person responsible for the repository assigned to the pull request?
  • Is the pull request linked to a project?
  • Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.

Fix CI workflow for fork repos
Fix missing doc
@R055A R055A added the bug Something isn't working label Mar 20, 2022
@R055A R055A added this to the Assignment 1 milestone Mar 20, 2022
@R055A R055A requested a review from a team as a code owner March 20, 2022 14:25
@R055A R055A self-assigned this Mar 20, 2022
@R055A R055A linked an issue Mar 20, 2022 that may be closed by this pull request
@R055A R055A merged commit 9c59209 into SE701-T5:main Mar 20, 2022
@R055A R055A deleted the fix-demo branch March 20, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix main repo for demonstration
2 participants