pushing to upstream on new branch Methanol #23
Conversation
…re made during conflict res. please review for those in mind
|
Thanks for the quick review. Looks like some duplicates were created when I tried to resolve conflicts with the master branch and merged. Please review with this in mind. Thank you! |
|
Issue #42 created: the methanol results are infeasible in both master and methanol branch. |
There was a problem hiding this comment.
There are a number of removed lines of code, besides the problem being now infeasible. Let's add the lines that were removed, and we can figure out the infeasibility later. I would suggest for the second one trying global LOA instead (it is very non-convex, so this might be the reason why the problem is infeasible). Another choice could be enumeration.
| @@ -59,11 +59,6 @@ def fix_vars_with_equal_bounds(m, tol=1e-8): | |||
| v.name, lb, ub | |||
| ) | |||
| ) | |||
| raise InfeasibleError( | |||
There was a problem hiding this comment.
It is a duplicate of above
| @@ -485,18 +479,6 @@ def _total_flow(_m, _s): | |||
| self.build_stream_doesnt_exist_con( | |||
| m.single_stage_recycle_compressor_disjunct, 32 | |||
| ) | |||
| self.build_stream_doesnt_exist_con( | |||
There was a problem hiding this comment.
Why are these constraints removed?
| @@ -545,31 +527,17 @@ def _total_flow(_m, _s): | |||
| * self.reactor_volume | |||
| * m.cheap_reactor.exists | |||
| ) | |||
| e -= ( | |||
| e -= self.cheap_reactor_fixed_cost * m.cheap_reactor.exists | ||
| e -= ( | ||
| self.expensive_reactor_variable_cost | ||
| * self.reactor_volume | ||
| * m.expensive_reactor.exists | ||
| ) | ||
| e -= ( |
There was a problem hiding this comment.
this is repeat from code below
| e -= self.expensive_reactor_fixed_cost * m.expensive_reactor.exists | ||
| e -= ( | ||
| (self.fix_electricity_cost + self.electricity_cost) | ||
| * m.single_stage_feed_compressor_disjunct.compressor_3.electricity_requirement | ||
| ) | ||
| e -= ( |
| @@ -579,23 +547,11 @@ def _total_flow(_m, _s): | |||
| (self.fix_electricity_cost + self.electricity_cost) | |||
| * m.two_stage_feed_compressor_disjunct.compressor_6.electricity_requirement | |||
| ) | |||
| e -= ( | |||
There was a problem hiding this comment.
duplicate lines of above
| @@ -609,18 +565,6 @@ def _total_flow(_m, _s): | |||
| self.cooling_cost | |||
| * m.two_stage_recycle_compressor_disjunct.cooler_18.heat_duty | |||
| ) | |||
| e -= ( | |||
There was a problem hiding this comment.
duplicate lines of above
| @@ -348,7 +343,6 @@ def _total_flow(_m, _s): | |||
| m.cheap_feed_disjunct.feed_cons = c = pe.ConstraintList() | |||
| c.add(m.component_flows[1, 'H2'] == m.flow_1_composition['H2'] * m.flows[1]) | |||
| c.add(m.component_flows[1, 'CO'] == m.flow_1_composition['CO'] * m.flows[1]) | |||
| c.add(m.component_flows[1, 'CO'] == m.flow_1_composition['CO'] * m.flows[1]) | |||
There was a problem hiding this comment.
this is the same line of code as above.
c.add(m.component_flows[1, 'CO'] == m.flow_1_composition['CO'] * m.flows[1])
The lines removed were duplicate lines. I tried enumerate_solutions(), that also gave us infeasible soln. |
Adding documentation try 1