Build fixes #184
Closed
Build fixes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ln --relative option is not available in fairly old versions of ln, which are still in use in older Linux distributions. Since the two use of ln --relative can very trivially be implemented differently in libselinux/src/Makefile, let's do so. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
PYCEXT is computed by asking the Python intrepreter what is the file extension used for native Python modules. Unfortunately, when cross-compiling, the host Python doesn't give the proper result: it gives the result matching the build machine, and not the target machine. Due to this, the symlink has an incorrect name, and doesn't point to the .so file that was actually built/installed. To address this and keep things simple, this patch just changes the ln invocation to rely on the name of the _selinux*.so Python module that was installed. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
tpetazzoni
force-pushed
the
build-fixes
branch
from
0d28d45
to
8ef6722
Compare
|
Can you send these via git send-email or equivalent to selinux @ vger.kernel.org? That's the preferred way for submitting selinux patches. |
|
Ah, yes, sure thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains two build fixes that were needed in the context of packaging SELinux in the Buildroot project. They are sent in a single pull request because even though they address different issues, the second commit modifies the same line of code as the first commit, even if for two completely different reasons.