Add label to input field (#2127)

SFDO-Tooling · Jun 5, 2023 · 3067d00 · 3067d00
1 parent 33ee4bb
commit 3067d00
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/locales/en/translation.json b/locales/en/translation.json
@@ -413,6 +413,7 @@
   "Title": "Title",
   "To go to your company’s login page, enter the custom domain name.": "To go to your company’s login page, enter the custom domain name.",
   "Type:": "Type:",
+  "Type to filter": "Type to filter",
   "Uh oh, we've encountered an error. You may need to": "Uh oh, we've encountered an error. You may need to",
   "Uh oh. There was an error communicating with your {{orgType}} for {{parent}} “{{name}}.”": "Uh oh. There was an error communicating with your {{orgType}} for {{parent}} “{{name}}.”",
   "Uh oh. There was an error communicating with your {{orgType}}.": "Uh oh. There was an error communicating with your {{orgType}}.",

diff --git a/locales_dev/en/translation.json b/locales_dev/en/translation.json
@@ -414,6 +414,7 @@
   "Timestamp": "Timestamp",
   "Title": "Title",
   "To go to your company’s login page, enter the custom domain name.": "To go to your company’s login page, enter the custom domain name.",
+  "Type to filter": "Type to filter",
   "Type:": "Type:",
   "Uh oh, we've encountered an error. You may need to": "Uh oh, we've encountered an error. You may need to",
   "Uh oh. There was an error communicating with your {{orgType}} for {{parent}} “{{name}}.”": "Uh oh. There was an error communicating with your {{orgType}} for {{parent}} “{{name}}.”",

diff --git a/src/js/components/githubUsers/assignTaskRole.tsx b/src/js/components/githubUsers/assignTaskRole.tsx
@@ -217,9 +217,10 @@ const AssignTaskRoleModal = ({
             slds-p-bottom_medium"
         >
           <Search
+            label={t('Search for user')}
             value={findText}
             assistiveText={{ label: t('Search for user') }}
-            placeholder={t('Search for user')}
+            placeholder={t('Type to filter')}
             onChange={handleFindTextChange}
             clearable
             onClear={handleClearFindText}

diff --git a/test/js/components/githubUsers/assignTaskRole.test.jsx b/test/js/components/githubUsers/assignTaskRole.test.jsx
@@ -93,7 +93,7 @@ describe('AssignTaskRole', () => {
   test('can filter by name/username', () => {
     const { getAllByText, getByPlaceholderText, getByText, queryByText } =
       setup();
-    const input = getByPlaceholderText('Search for user');
+    const input = getByPlaceholderText('Type to filter');
 
     expect(queryByText('No users found.')).toBeNull();