Fix #162 and #166 #168
Merged
Fix #162 and #166 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eXpl0it3r
approved these changes
Sep 17, 2019
|
Looks ok 👍 @eXpl0it3r is it you or me who merges for SFML.Net? 😁 |
This was referenced Sep 18, 2019
|
@LaurentGomila I guess both depending on the situation. 😉 |
|
Any other SFML.Net user to review this PR before I merge it? |
|
I'll have another look through as I did on the previous PR this replaced. |
Rosst0pher
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, added a number of inline XML documentations for otherwise undocumented fields/methods/classes
This PR is an attempt to clean up what had become quite hideous in terms of number and quality of commits. It replaces #167 to fix #162 and #166