-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename readme.txt to README.md & update links #181
Conversation
Also added a Travis badge to help identify where the CI is hosted at, although very happy to undo that if it's not a desired change! |
I believe it makes sense to align it with how the official SFML repo looks like. 👍 But since we're already using Markdown, might make sense to actually transform the URLs to text links. |
Thanks for the very prompt responses! Just updated the rest of the text links |
All the changes seems fine, I would like to see the commits squashed, personally. Other than that, 👍 |
eb926d6
to
6a347b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really your fault, but the README hasn't been updated in a while, sooo a few smaller changes are desired 😅
7c50833
to
4ab2f10
Compare
No worries! Think that's all fixed now |
Actually hold on this, I just realised there are links to this file within the repo so will fix those |
4ab2f10
to
825332e
Compare
All good, there was just the one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah just as I thought it was done, I saw some minor things again 🙈
Just fixed those, will squash later when I get home from work |
Any chance to get it squashed? :) |
d29c7ef
to
2719884
Compare
Sorry, lost track of time -- squashed now 😅 |
GitHub natively renders this file without any changes very nicely as a Markdown file, whereas it's currently rendering it in plaintext
See:
https://github.com/SFML/SFML.Net/blob/master/readme.txt
https://github.com/SFML/SFML.Net/blob/76f05c206da7f021f63797c28023ed59a2ec6215/README.md