Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rect Contains With Vector2 #191

Merged
merged 1 commit into from
May 27, 2024
Merged

Rect Contains With Vector2 #191

merged 1 commit into from
May 27, 2024

Conversation

charleyah
Copy link
Contributor

Adds Contains overload with Vector2 position for FloatRect and IntRect structures

@charleyah charleyah marked this pull request as draft July 30, 2020 15:29
@charleyah charleyah marked this pull request as ready for review July 30, 2020 15:30
DemoXinMC
DemoXinMC suggested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@DemoXinMC DemoXinMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vector2u also exists, and while not likely commonly used, for completeness sake, let's go ahead and add an overload for that as well.

@charleyah
Copy link
Contributor Author

Added overloads for all Vector2 variants

@charleyah charleyah force-pushed the feature/convenient-overloads branch from 19f591f to c438ccc Compare July 30, 2020 16:15
@eXpl0it3r eXpl0it3r mentioned this pull request May 23, 2024
Closed
22 tasks
@eXpl0it3r eXpl0it3r added the Feature New functionality or extending of an existing one label May 27, 2024
eXpl0it3r
eXpl0it3r approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@eXpl0it3r eXpl0it3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this adjustment!

@eXpl0it3r eXpl0it3r merged commit 857906a into SFML:master May 27, 2024
@eXpl0it3r eXpl0it3r added this to the 2.6.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eXpl0it3r eXpl0it3r eXpl0it3r approved these changes

@DemoXinMC DemoXinMC DemoXinMC approved these changes

@Marioalexsan Marioalexsan Marioalexsan approved these changes

Assignees
No one assigned
Labels
Feature New functionality or extending of an existing one
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@charleyah @eXpl0it3r @DemoXinMC @Marioalexsan