FIxes Missing Access Modifier Warnings #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing access modifiers to pinvoke methods
Adds missing access modifiers to pinvoke methods
Adds missing access modifiers to pinvoke methods
adds missing access modifiers to pinvoke methods
eXpl0it3r
approved these changes
Jan 13, 2022
eXpl0it3r
added
Feature
|
Thanks again for this clean up 🧹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactor across SFML.Net that resolves all 457 warnings of missing access modifiers (IDE0040). My original motive to do this was due to missing access modifiers being part of bug #207.
All 457 warnings are missing access modifiers for the pinvoke methods and so this PR adds
privatemodifier to all pinvoke methods as thats the default when not specified.Some diffs show entire source files being changed which is a result of some source files having mixed file endings and I've set it to whatever I found to be the common in the relevant project.
In terms of testing, I've done some basic feature tests such as shape rendering and playing music. As this is a sweeping change across the entire project, I encourage some thorough code reviewing and understand if this PR gets put on hold for a future major version change.
This wasn't just a find and replace effort and was an opportunity to also check over every PInvoke method and their CSFML counterparts, which has uncovered other issues of various severity that I'll raise separately after creating this PR.